Skip to content

Fix in tag.py#116

Merged
ortex merged 1 commit into
roc-streaming:mainfrom
gavv:main
Sep 30, 2023
Merged

Fix in tag.py#116
ortex merged 1 commit into
roc-streaming:mainfrom
gavv:main

Conversation

@gavv

@gavv gavv commented Sep 30, 2023

Copy link
Copy Markdown
Member

Changes:

  • Fix error
  • Show status
  • Sort imports

Error was:

./tag.py --push origin v0.2.2
--- Updating version in roc/version.go to 0.2.2
Traceback (most recent call last):
  File "/home/victor/dev/roc-streaming/roc-go/./tag.py", line 91, in <module>
    main()
  File "/home/victor/dev/roc-streaming/roc-go/./tag.py", line 84, in main
    commit_change(version, force)
TypeError: commit_change() takes 1 positional argument but 2 were given

@gavv gavv requested a review from ortex September 30, 2023 09:07
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 95.037%. remained the same when pulling 7497627 on gavv:main into 963cc75 on roc-streaming:main.

@ortex ortex merged commit 5f72459 into roc-streaming:main Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants