Skip to content

add tests convert functions#49

Merged
gavv merged 4 commits into
roc-streaming:mainfrom
ortex:tests-convert
Mar 3, 2023
Merged

add tests convert functions#49
gavv merged 4 commits into
roc-streaming:mainfrom
ortex:tests-convert

Conversation

@ortex

@ortex ortex commented Feb 27, 2023

Copy link
Copy Markdown
Member

#45

@coveralls

coveralls commented Feb 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

Coverage: 72.939% (+0.4%) from 72.516% when pulling b58cfa7 on ortex:tests-convert into 8135b30 on roc-streaming:main.

gavv
gavv reviewed Feb 27, 2023
View reviewed changes

@gavv gavv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

Comment thread roc/convert_test.go Outdated
@gavv gavv added the status: needs revision Pull request should be revised by its author label Mar 1, 2023
gavv
gavv reviewed Mar 2, 2023
View reviewed changes
Comment thread roc/convert.go
Comment thread roc/convert_test.go Outdated
Comment thread roc/convert_test.go
@gavv

gavv commented Mar 2, 2023

Copy link
Copy Markdown
Member

#50

@gavv gavv mentioned this pull request Mar 2, 2023
Closed
@gavv gavv merged commit c445824 into roc-streaming:main Mar 3, 2023
@gavv

gavv commented Mar 3, 2023

Copy link
Copy Markdown
Member

Thanks!

@gavv gavv removed the status: needs revision Pull request should be revised by its author label Mar 3, 2023
@ortex ortex deleted the tests-convert branch March 4, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavv gavv gavv left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ortex @coveralls @gavv