add gofmt step to ci

[wataru-nakanishi]

PR for #86

Implemented

• Add gofmt CI step

This is my first contributing!
If the contributing process was wrong, please tell me.

[coveralls]

Coverage: 94.04%. Remained the same when pulling 69f2983 on wataru-nakanishi:add_gofmt into 9647d5d on roc-streaming:main.

[wataru-nakanishi]

@roc-streaming/go ready for review

[wataru-nakanishi]

I added fmt step only in linux.
Because Jerome1337/gofmt-action@v1.0.5 is available in linux only.

https://github.com/roc-streaming/roc-go/actions/runs/5029732462/jobs/9021655456
Error: Container action is only supported on Linux

[gavv]

Thanks for PR! Using linux is perfectly ok, we don't need to check formatting on each OS because results would be the same.

I suggest extracting formatting check into a separate job "Formatting". It's not really bound to any steps in "Linux" job and can be done separately.

[gavv]

Follow-up issue: https://github.com/roc-streaming/roc-go/issues/92

[gavv]

@wataru-nakanishi Could you please check if this CI step will fail if a file has no newline at the end? If it won't, I think I'll create a separate issue for adding such step too.

[wataru-nakanishi]

@gavv
Thank you!
Fixed. ec6806c

Could you please check if this CI step will fail if a file has no newline at the end? If it won't, I think I'll create a separate issue for adding such step too.

I added a new line to config.go and CI failed.
Originally, there is no new line
https://github.com/roc-streaming/roc-go/actions/runs/5035614704/jobs/9031245933?pr=91

[gavv]

I added a new line to config.go and CI failed.
Originally, there is no new line

I actually mean the opposite case: not when extra newline is added, but when the last one is missing.

[wataru-nakanishi]

@gavv
CI check didn't fail if a file has no newline at the end.
For example, config.go has no new line.
https://github.com/roc-streaming/roc-go/blob/main/roc/config.go#L494

Please let me know if I'm misunderstanding.

[gavv]

config.go does have newline at the end. It's last symbol is LF, not "}". If there were no terimnating LF, github would display that red icon that I showed above.

[wataru-nakanishi]

@gavv

config.go does have newline at the end. It's last symbol is LF, not "}". If there were no terimnating LF, github would display that red icon that I showed above.

Thanks for letting me know.
CI failed if a file has no new line.
https://github.com/roc-streaming/roc-go/actions/runs/5035923474/jobs/9031753001?pr=91

[gavv]

Thanks!! So we don't need one more check, gofmt already checks everything we need.

One more comment: could you please place formatting job before release job, and add formatting job to the list of dependencies of release job?

[wataru-nakanishi]

@gavv

could you please place formatting job before release job, and add formatting job to the list of dependencies of release job?

fixed! 69f2983

[gavv]

LGTM