updated yank error message

[mikastiv]

Fixes #8695

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[Eh2406]

I think there will probably need to be tests updated. If not then we will need to figure out how to add a test.

@ehuss What do you think of the new text?

[ehuss]

Perhaps .required(true) can just be added to the --vers flag and let clap handle it. That would make the help text better (it explicitly shows --vers is required), and the error would look like this:

error: The following required arguments were not provided:
    --vers <VERSION>

USAGE:
    cargo yank [OPTIONS] --vers <VERSION> [--] [crate]

For more information try --help

[mikastiv]

This works better and is a good idea, but now the test alt_registry::bad_registry_name fails because it expects the --vers argument. Should I remove yank cmd from this test? Or maybe I put the required at the wrong place

[mikastiv]

It works using .required_unless("registry"). Would this be a good option?

[ehuss]

You can just put in a bogus version to fix that test, like this:

diff --git a/tests/testsuite/alt_registry.rs b/tests/testsuite/alt_registry.rs
index f9129e284..c3ed37633 100644
--- a/tests/testsuite/alt_registry.rs
+++ b/tests/testsuite/alt_registry.rs
@@ -637,7 +637,7 @@ Caused by:
         "owner",
         "publish",
         "search",
-        "yank",
+        "yank --vers 1.2.3",
     ] {
         p.cargo(cmd)
             .arg("--registry")

[mikastiv]

Alright I did it.

[ehuss]

Thanks!
@bors r+

[bors]

📌 Commit 51fa3a4 has been approved by ehuss

[bors]

⌛ Testing commit 51fa3a4 with merge 8777a6b...

[bors]

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 8777a6b to master...