Conversation
The old androideabi uses armv5 and thus also needs the atomic emulation and because Android is basically Linux it can use the same implementation.
Author
|
Would you mind publishing a new version, so that these changes can be included in the rust repository? |
Member
|
Published 0.1.44. |
Contributor
|
@ATiltedTree just a heads up this was partially reverted in #450 |
tgross35
pushed a commit
that referenced
this pull request
Jan 31, 2026
Include Linux atomic emulation on androideabi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old
androideabiusesarmv5and thus also needs the atomic emulation and because Android is basically Linux it can use the same implementation.This has been verified by taking a old
libgccfrom a ndk toolchain to a dissassembler:__sync_fetch_and_add_4as an example0xffff0fc0being the address of the kuser functionkuser_cmpxchg.Reason for this change: rust-lang/rust#85806 (comment)