Skip to content

Add semaphore APIs#309

Merged
bors merged 1 commit into
rust-lang:masterfrom
sfackler:sem
Jun 6, 2016
Merged

Add semaphore APIs#309
bors merged 1 commit into
rust-lang:masterfrom
sfackler:sem

Conversation

@sfackler

@sfackler sfackler commented Jun 4, 2016

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

Copy link
Copy Markdown

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@sfackler sfackler force-pushed the sem branch 10 times, most recently from 3ebc3f7 to 36b317f Compare June 4, 2016 17:25
@sfackler

sfackler commented Jun 4, 2016

Copy link
Copy Markdown
Member Author

Builds pass

Comment thread src/unix/notbsd/android/mod.rs Outdated
}

pub struct sem_t {
pub count: ::c_uint,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this could be opaque like the other platforms? That'd mean the special case in build.rs could be removed as well

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(also applicable with musl below)

@alexcrichton

Copy link
Copy Markdown
Member

Nice! All looks good to me, just a minor nit about making the fields private (to avoid some extra libc-test logic), but other than that r=me

@sfackler

sfackler commented Jun 5, 2016

Copy link
Copy Markdown
Member Author

Updated

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 41699f7

@bors

bors commented Jun 6, 2016

Copy link
Copy Markdown
Contributor

⌛ Testing commit 41699f7 with merge d1f4c2d...

bors added a commit that referenced this pull request Jun 6, 2016
@bors

bors commented Jun 6, 2016

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, travis

@bors bors merged commit 41699f7 into rust-lang:master Jun 6, 2016
bors added a commit that referenced this pull request Jun 10, 2016
Fix semaphores on Solaris/Illumos

This adds `sem_t` structure introduced in #309 and fixes compilation on Solaris.
@sfackler sfackler deleted the sem branch November 26, 2016 04:49
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
Update signalfd

Update `signalfd` to use types and functions from `libc`.

It is a breaking change, because:
- renamed pub const `CREATE_NEW_FD` to `SIGNALFD_NEW`
- renamed pub const `SIGINFO_SIZE` to `SIGNALFD_SIGINFO_SIZE`
- removed pub const `SIGINFO_PADDING`

Fixes rust-lang#307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants