fix: Port block and loop inference from rustc#22473
Merged
ChayimFriedman2 merged 2 commits intoMay 28, 2026
Merged
Conversation
Veykril
approved these changes
May 28, 2026
Contributor
Author
|
New Rust, new Clippy! |
This fixes one diagnostic on self.
I.e., consider a block diverging if its tail expr is diverging, even if it doesn't have type never. This became important now that blocks coerce the tail expression's type to the expected type instead of coercing themselves, but in fact the logic was always incorrect - a statement *in the middle of* a block can be diverging without the block having never type. This situation is still not handled correctly, which is why I also left a comment for maybe having a side map for this.
5e38fc2 to
e5faf6a
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.