Skip to content

internal: incentivize rust-analyzed developers to fix panics#9937

Merged
bors[bot] merged 1 commit into
rust-lang:masterfrom
matklad:noisy-panic
Aug 22, 2021
Merged

internal: incentivize rust-analyzed developers to fix panics#9937
bors[bot] merged 1 commit into
rust-lang:masterfrom
matklad:noisy-panic

Conversation

@matklad

@matklad matklad commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread crates/rust-analyzer/src/lsp_utils.rs Outdated
@matklad matklad marked this pull request as ready for review August 22, 2021 14:43
@matklad

matklad commented Aug 22, 2021

Copy link
Copy Markdown
Contributor Author

bors r+

bors Bot added a commit that referenced this pull request Aug 22, 2021
9937: wip: pester devs to fix panics r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@matklad matklad changed the title wip: pester devs to fix panics internal: incentivize rust-analyzed developers to fix panics Aug 22, 2021
@matklad

matklad commented Aug 22, 2021

Copy link
Copy Markdown
Contributor Author

bors r-

@bors

bors Bot commented Aug 22, 2021

Copy link
Copy Markdown
Contributor

Canceled.

@matklad

matklad commented Aug 22, 2021

Copy link
Copy Markdown
Contributor Author

bors r+

It's good that rust-analyzer doesn't belly-up on a panic in some random
assist.

It is less good that rust-analyzer devs only know that the assists are
buggy when they are actively looking at the logs.
@bors

bors Bot commented Aug 22, 2021

Copy link
Copy Markdown
Contributor

Canceled.

@matklad

matklad commented Aug 22, 2021

Copy link
Copy Markdown
Contributor Author

bors r+

@bors

bors Bot commented Aug 22, 2021

Copy link
Copy Markdown
Contributor

@bors bors Bot merged commit 0960d4e into rust-lang:master Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants