move multiple_bound_locations to style#16302
Merged
Merged
Conversation
Collaborator
Contributor
|
Thank you. |
pull Bot
pushed a commit
to Mattlk13/rust-clippy
that referenced
this pull request
May 21, 2026
The lint fires on `.get(...).is_some()` (or `.is_none()`) against `HashSet`/`BTreeSet`/`HashMap`/`BTreeMap` and suggests `.contains()` / `.contains_key()`. The two forms are semantically equivalent and the suggestion is purely a readability/shortness refactor, so `complexity` reads as a better fit than `suspicious` per the descriptions in the clippy book: - `suspicious` — "code that is most likely wrong or useless" - `complexity` — "suggestions on how to simplify your code... in a shorter and more readable way, while preserving the semantics" rust-lang#16302 made the same kind of move for `multiple_bound_locations` (`suspicious` -> `style`) with similar reasoning, so there is precedent for adjusting a lint's category when it no longer matches the original placement. Happy to drop this if the team prefers to keep it in `suspicious`; the issue reporter raised the case and the category boundary is a judgement call. Fixes rust-lang#16990. changelog: move `unnecessary_get_then_check` lint to `complexity` group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
multiple_bound_locationslint fromsuspicioustostyle. Thesuspiciouscategory is described as "code that is most likely wrong or useless", which is not the case here at all, sostyleseems more fitting.Fixes #15736, with some prior discussion at rust-lang/rust#146540.
changelog: move
multiple_bound_locationslint tostylegroup