Fix explicit_counter_loop FP when the counter is only modified inside the else block of let...else binding.#17023
Merged
Conversation
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Jarcho
requested changes
May 21, 2026
Comment on lines
+50
to
+59
| if let Some(els) = l.els { | ||
| if let Some(init) = l.init { | ||
| self.visit_expr(init); | ||
| } | ||
| self.depth += 1; | ||
| self.visit_block(els); | ||
| self.depth -= 1; | ||
| } else { | ||
| walk_local(self, l); | ||
| } |
Contributor
There was a problem hiding this comment.
Can just be:
if let Some(init) = l.init {
self.visit_expr(init)
if let Some(els) = l.els {
self.depth += 1;
self.visit_block(els);
self.depth -= 1;
}
}Note that walk_local doesn't actually do anything other than waste time.
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
the `else` block of `let...else` binding.
028f495 to
22833b4
Compare
Contributor
Author
|
@rustbot ready |
Jarcho
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #17014
changelog: [
explicit_counter_loop]: Fix FP when the counter is only modified inside theelseblock oflet...elsebinding.