Fix result_large_err and result_unit_err not triggering on async functions#17130
Merged
Conversation
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
samueltardieu
requested changes
Jun 2, 2026
| @@ -351,6 +351,7 @@ impl AsyncResultLenWithoutIsEmpty { | |||
|
|
|||
| pub async fn len(&self) -> Result<usize, ()> { | |||
| //~^ len_without_is_empty | |||
| //~| result_unit_err | |||
Member
There was a problem hiding this comment.
You're not testing for this lint here, so you should use #[expect(result_unit_err)] above the function.
| @@ -364,6 +365,7 @@ impl AsyncOptionLen { | |||
| } | |||
|
|
|||
| pub async fn len(&self) -> Result<usize, ()> { | |||
| //~^ result_unit_err | |||
Comment on lines
+45
to
+46
| if ty.is_diag_item(cx, sym::Result) | ||
| && let ty::Adt(_, args) = ty.kind() |
Member
There was a problem hiding this comment.
This would do less duplicated work:
Suggested change
| if ty.is_diag_item(cx, sym::Result) | |
| && let ty::Adt(_, args) = ty.kind() | |
| if let ty::Adt(adt_def, args) = ty.kind() | |
| && cx.tcx.is_diagnostic_item(sym::Result, adt_def.did()) |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
Author
|
@rustbot ready |
samueltardieu
approved these changes
Jun 2, 2026
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #17070
while working on the issue I also found that
result_unit_erralso had the same problem, which should also be fixed now.changelog: fix [
result_large_err] and [result_unit_err] not triggering on async functions.