borrowed_box: clean-up, improve suggestion message#17173
Merged
Conversation
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Lintcheck changes for 15c9677
This comment will be updated if you push new changes |
separate commit to improve diffs
- Do the cheaper `Mutability` test first. - Extract `Res` out of `Path`, since we're fetching the latter anyway. Avoids the call to `LateContext::qpath_res` which does the same thing. - `is_any_trait`: get diagnostic item once -- this is an expensive function - Move snippet creation inside `span_lint_and_then` -- improves laziness.
- rename test file to match lint name - calling functions from main isn't necessary for the test to work
borrowed_box: clean-upborrowed_box: clean-up, improve suggestion message
Contributor
|
Thank you! LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: none