-
-
Notifications
You must be signed in to change notification settings - Fork 15k
tidy: Add a check for empty .stderr and .stdout files in UI test directories #50785
Copy link
Copy link
Closed
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Description
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Tidy check in https://github.com/rust-lang/rust/blob/master/src/tools/tidy/src/ui_tests.rs makes sure that we don't have stray
testname.stderr/testname.stdoutfiles without a correspondingtestname.rs.It would be useful to add one more check into the same file making sure that
testname.stderr/testname.stdoutfiles are not empty.Such empty files can still pass testing for
compile-passtests with no output so they can get into the repo accidentally, but they are not necessary and can be removed.