-
-
Notifications
You must be signed in to change notification settings - Fork 15k
edition lint: migrating extern crate with #[macro_use] #52043
Copy link
Copy link
Open
Labels
A-edition-2018Area: The 2018 editionArea: The 2018 editionA-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.L-macro_use_extern_crateLint: macro_use_extern_crateLint: macro_use_extern_crateT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Metadata
Metadata
Assignees
Labels
A-edition-2018Area: The 2018 editionArea: The 2018 editionA-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.Area: Lints (warnings about flaws in source code) such as unused_mut.C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.L-macro_use_extern_crateLint: macro_use_extern_crateLint: macro_use_extern_crateT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
The migration issue is that
#[macro_use] extern crate foo;beings macros into scope fromfooandextern crateis unidiomatic in the 2018 edition.local_inner_macrosis the current solution but as discussed in #50911, we're not 100% that works.