-
-
Notifications
You must be signed in to change notification settings - Fork 15k
Fatal error when running ./x.py test without .git directory #70182
Copy link
Copy link
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
When running
./x.py testwithout a Git repo (i.e., no.gitdirectory), I get the following:Apparently this is due to tidy/rustfmt. (Thanks to @Mark-Simulacrum for this suggestion.) So, if I add
--exclude src/tools/tidyto the command line, it all works. However, it would be nice if it could handle no.gitdirectory automatically.CC @pnkfelix