-
-
Notifications
You must be signed in to change notification settings - Fork 15k
Web Assembly Atomic fence support in atomic::fence #72997
Copy link
Copy link
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.O-wasmTarget: WASM (WebAssembly), http://webassembly.org/Target: WASM (WebAssembly), http://webassembly.org/T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.O-wasmTarget: WASM (WebAssembly), http://webassembly.org/Target: WASM (WebAssembly), http://webassembly.org/T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
The function
pub fence(order: Ordering)inlibcore/sync/atomic.rsdoes nothing when compiled for Web Assembly.This stem from an old issue in web assembly #WebAssembly/tool-conventions/issues/59 and LLVM crashing (at the time) with it.
This has since been fixed, notably for LLVM, maybe we can remove the
#[cfg(...)]and comment about it ?