Revert "Rollup merge of #137268 - bjoernager:c-string-eq-c-str, r=Amanieu"

[workingjubilee]

This reverts commit 30550c0, reversing changes made to 36b2163.

This is an experiment for purposes of retrying the relevant crater run on a list of crates that I believe failed for questionable reasons.

r? @ghost

[workingjubilee]

@bors2 try

[rust-bors]

⌛ Trying commit 22407dc with merge 998b660…

To cancel the try build, run the command @bors2 try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 998b660 (998b6603a58e47f42ccce7a67943234e96b6839e, parent: cf38b8e663f15db10ce49d7bbce02c99fc3dbc0c)

[workingjubilee]

@craterbot check crates=https://gist.githubusercontent.com/workingjubilee/a9a53de0813bb3bb44935a58ec3eb71a/raw/b061ade3f93717641fc6a4eeaee71a2b34ddc9fd/retry-error-list.txt

[craterbot]

🚨 Error: missing desired crates: {"vebex", "suifrs", "rhash_derive", "kbrain", "theora-rs-sys", "wepay", "adflib-cli", "rtop-rust", "sew", "v-ayylmao", "axum-oas", "zuck", "rhash", "p2ps", "scpull", "kaparser", "elephant", "visuo-rs", "hls-to-udp", "warrior", "hardlight", "pixels-cli", "sphinx-use-state", "wasm-emit-text", "sentinels", "cargo-rune", "amongos", "le-petit-lapin", "illuminate-contracts", "annie", "trustcaptcha-rust", "illuminate-container", "web3canister", "zinc-rs", "zeuhl_matrix", "gardens-rs", "sstv", "gabs", "adoc", "cec1734-pac", "gest", "eleph", "chakrapy", "udp-to-hls", "degu", "algorust", "cec1736-pac", "expression-parser", "aix", "auto-lsp-macros", "cforge", "jili", "proxy-map", "solace", "cody-c", "amestris", "cw-argon2", "gettext-rs-dummy", "xie", "v464", "sexually_transmitted_disease", "emit-jvm-bytecode", "illuminate-support", "bak8", "tls-cert-gen-lib", "illuminate", "rozen", "deadhand", "art_dewjjj", "bak8-lib-os", "create-github-app-token", "rox-lang", "gsi-csgo", "charly", "xext-sql", "ctool", "rucat_client", "sps-aio", "random_num", "rsllm", "tohsaka", "qfin-broker", "novo", "libkuiper", "cargone", "nexus_force", "rodent", "clatd", "chip-8-compiler", "cec1712-pac", "gitbook", "pbox", "ftfrs", "ircv3_tags", "patio", "pass-rs", "cob", "qst", "rish", "bak8-bak", "refactor", "async-pidfd-next", "bbtk", "porch", "simdutf16", "graphy", "cw-simple-auth", "kosen", "annasul_core", "dao-ansi", "rgode", "simple-chunk-allocator", "asmov-common-traitenum-macro", "gmx", "rspice", "airs", "rustdown", "profane-rs", "graphs", "ghz", "hyper-archive", "wally-vibe", "funcy", "squeel", "cargo-ui-cli", "phobia", "numjj", "konkord", "tdameritrade", "e_macro", "scan2", "qbdi-rs", "lake", "xext-duckdb-type", "rust_tcp_sever", "deux", "testCargo", "xmss", "cw721-base-utils", "jstr", "rxegy-sys", "abook", "ikbr", "keyfn-closures", "grathe", "glances", "gaggle", "typora", "ksar", "smolcrush", "scm-cli", "snail_image_confuse", "kozi", "the-bridge", "whiskers-launcher-core", "toast-cli", "annasul_macro", "fountain-parser-rs", "initializr", "atomic-ext", "annasul_framework", "cargo-axum", "rusty_ollama", "asmov-common-traitenum-parse", "shin", "ksni-dummy", "cw-aes-gcm-siv", "vextractor-cli", "cresselia", "ipv10", "librender", "worktrace", "sphinx", "glfw-rs", "pangea", "rs-logger", "qfin-math", "bakalari", "jakt", "explorer", "gsi-cs2", "cargo-rpc", "spoilers", "dns64", "ina", "noor", "aksk", "weipay", "my_crate_dewjjj", "rucat_common", "layerzero_scan_client", "atom-archive", "defituna-txsender", "vextractor", "gnu", "snail_sort", "drifter", "redo", "testCargoTwo", "cw-bech32", "kt2", "xc220b3", "ulrish", "rendology", "reqres", "baburu-macros", "xext-tokio", "dirz", "rust-bench-output", "lingxi", "nukly", "glfw-rs-sys", "swarm", "atomcrypte", "tray-icon-dummy", "nein", "deltaml", "crate_a", "ubend", "arch_words", "prefer-dynamic2", "filament-sys", "rzsc", "dorian", "thresh-sig", "rsprobe", "greek", "cake_aes", "gavrillmq", "harmless", "ameritrade", "platd", "uniswap", "qt6-rs", "csgo-gsi3", "asuka", "wonderland", "grip", "tembo", "dep-inj-target", "static_mime", "dreamer", "rtx-cli-test", "cargo-dioxus", "libebpfverifier-sys", "neostream", "ssh_to_solana", "learn_rust_xxx", "frandb", "hydraproxy", "hoverbear", "hikari", "ovo", "felysium", "kmao_decrypt_bin", "nvme", "isoperm", "yuan", "casa", "const_ptr", "veryfast", "Jinn", "fakecorr", "annasul_build", "rust-shapefile", "dnn", "leopard", "h2o", "koro", "glyph", "xext-build-utils", "ss-sharing", "ars", "venture_league", "foldy", "baburu_core", "double-ratchet-rs", "cobol", "asmov-common-traitenum-cargo", "yuu", "crate_b", "hardlight-macros", "asmov-common-traitenum", "pretty-menu"}

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[workingjubilee]

@craterbot check crates=https://gist.githubusercontent.com/workingjubilee/a9a53de0813bb3bb44935a58ec3eb71a/raw/4baf02cd1c5359bbe6ff58e319b735a7eb3ed1a1/retry-error-list-1.txt

[craterbot]

👌 Experiment pr-143170 created and queued.
🤖 Automatically detected try build 998b660
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-143170 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-143170 is completed!
📊 1 regressed and 2 fixed (147991 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[workingjubilee]

hm.

okay, rustix may have regressed but we're not seeing a ton of differences here in the remaining sample, seems like a correct decision.