Skip to content

Fix grammar in Pin documentation#153569

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
abh1nav10:fix-pin-docs
Mar 13, 2026
Merged

Fix grammar in Pin documentation#153569
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
abh1nav10:fix-pin-docs

Conversation

@abh1nav10

@abh1nav10 abh1nav10 commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Changed "has an address-sensitive" to "has address-sensitive states" in the Drop implementation section of the documentation of Pin thereby making it grammatically complete.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 8, 2026
@rustbot

rustbot commented Mar 8, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, joboet, scottmcm

joboet
joboet reviewed Mar 12, 2026
View reviewed changes

@joboet joboet left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! While you're at it, could you fix the other grammar issue in the line as well?

View changes since this review

Comment thread library/core/src/pin.rs Outdated
//!
//! This can never cause a problem in purely safe code because creating a pinning pointer to
//! a type which has an address-sensitive (thus does not implement `Unpin`) requires `unsafe`,
//! a type which has address-sensitive states (thus does not implement `Unpin`) requires `unsafe`,

@joboet joboet Mar 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! a type which has address-sensitive states (thus does not implement `Unpin`) requires `unsafe`,
//! a type which has address-sensitive states (and thus does not implement `Unpin`) requires `unsafe`,

@abh1nav10 abh1nav10 Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@abh1nav10 abh1nav10 requested a review from joboet March 13, 2026 06:40
@joboet

joboet commented Mar 13, 2026

Copy link
Copy Markdown
Member

Thanks!
@bors r+ rollup

@rust-bors

rust-bors Bot commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 4916314 has been approved by joboet

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2026
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 13, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Mar 13, 2026
@bors
Auto merge of #153832 - matthiaskrgr:rollup-tOzZz0L, r=matthiaskrgr
1d8897a 
Rollup of 3 pull requests

Successful merges:

 - #153418 (core: remove FIXME comment in option.rs FromIterator)
 - #153569 (Fix grammar in Pin documentation)
 - #153798 (Remove unused `SelectionCandidate::PointerLikeCandidate`)
@rust-bors rust-bors Bot merged commit 42c7f52 into rust-lang:main Mar 13, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joboet joboet Awaiting requested review from joboet

Assignees

@joboet joboet

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@abh1nav10 @rustbot @joboet