add regression test for Redundant memory strores with mut parameters …#154841
Merged
rust-bors[bot] merged 1 commit intoApr 6, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
70fb4aa to
7db8c34
Compare
This comment has been minimized.
This comment has been minimized.
…in by-value returns
7db8c34 to
519a555
Compare
Member
|
@bors r+ rollup |
Contributor
Member
|
@bors maybe |
Contributor
|
Unknown command "maybe". Run |
github-actions Bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Apr 7, 2026
Rollup of 4 pull requests Successful merges: - rust-lang/rust#152853 (deny-by-default & report in deps `uninhabited_static`) - rust-lang/rust#153615 (fixed generics of crate node ICE) - rust-lang/rust#154744 (Remove `Clone` impl for `StableHashingContext`.) - rust-lang/rust#154841 (add regression test for Redundant memory strores with mut parameters …)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 18, 2026
…vooeo Revert "add regression test for Redundant memory strores with mut parameters in by-value returns" This reverts commit 519a555 (PR rust-lang#154841). The regression test added by that commit asserts that redundant stores are present, which locks in suboptimal assembly output and will actively block any future fix from landing. The underlying issue (rust-lang#149762) is therefore not fixed. Since 1.92.0, both `with_rebind` and `with_mut_param` compile to the same suboptimal assembly, whereas in 1.91.0 `with_rebind` at least produced optimal output. A correct regression test should verify that neither function emits redundant stores, and should be added together with an actual fix. rust-lang#149762 (comment)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 18, 2026
…vooeo Revert "add regression test for Redundant memory strores with mut parameters in by-value returns" This reverts commit 519a555 (PR rust-lang#154841). The regression test added by that commit asserts that redundant stores are present, which locks in suboptimal assembly output and will actively block any future fix from landing. The underlying issue (rust-lang#149762) is therefore not fixed. Since 1.92.0, both `with_rebind` and `with_mut_param` compile to the same suboptimal assembly, whereas in 1.91.0 `with_rebind` at least produced optimal output. A correct regression test should verify that neither function emits redundant stores, and should be added together with an actual fix. rust-lang#149762 (comment)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 18, 2026
…vooeo Revert "add regression test for Redundant memory strores with mut parameters in by-value returns" This reverts commit 519a555 (PR rust-lang#154841). The regression test added by that commit asserts that redundant stores are present, which locks in suboptimal assembly output and will actively block any future fix from landing. The underlying issue (rust-lang#149762) is therefore not fixed. Since 1.92.0, both `with_rebind` and `with_mut_param` compile to the same suboptimal assembly, whereas in 1.91.0 `with_rebind` at least produced optimal output. A correct regression test should verify that neither function emits redundant stores, and should be added together with an actual fix. rust-lang#149762 (comment)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 18, 2026
…vooeo Revert "add regression test for Redundant memory strores with mut parameters in by-value returns" This reverts commit 519a555 (PR rust-lang#154841). The regression test added by that commit asserts that redundant stores are present, which locks in suboptimal assembly output and will actively block any future fix from landing. The underlying issue (rust-lang#149762) is therefore not fixed. Since 1.92.0, both `with_rebind` and `with_mut_param` compile to the same suboptimal assembly, whereas in 1.91.0 `with_rebind` at least produced optimal output. A correct regression test should verify that neither function emits redundant stores, and should be added together with an actual fix. rust-lang#149762 (comment)
rust-timer
added a commit
that referenced
this pull request
Jun 18, 2026
Rollup merge of #158048 - Filiprogrammer:revert-154841, r=Kivooeo Revert "add regression test for Redundant memory strores with mut parameters in by-value returns" This reverts commit 519a555 (PR #154841). The regression test added by that commit asserts that redundant stores are present, which locks in suboptimal assembly output and will actively block any future fix from landing. The underlying issue (#149762) is therefore not fixed. Since 1.92.0, both `with_rebind` and `with_mut_param` compile to the same suboptimal assembly, whereas in 1.91.0 `with_rebind` at least produced optimal output. A correct regression test should verify that neither function emits redundant stores, and should be added together with an actual fix. #149762 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #149762
r? compiler