fix(clippy): std_instead_of_core false positive for core::io#156164
Closed
bushrat011899 wants to merge 1 commit into
Closed
fix(clippy): std_instead_of_core false positive for core::io#156164bushrat011899 wants to merge 1 commit into
std_instead_of_core false positive for core::io#156164bushrat011899 wants to merge 1 commit into
Conversation
Collaborator
|
The Clippy subtree was changed cc @rust-lang/clippy |
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Could you please submit this Clippy-only PR to https://github.com/rust-lang/rust-clippy instead? |
Contributor
Author
|
Can do! Apologies for the mixup. |
pull Bot
pushed a commit
to asukaminato0721/rust-clippy
that referenced
this pull request
Jun 16, 2026
…t-lang#16964) # Objective - Fix false positive identified by @rktaxe in [this comment](rust-lang#13158 (comment)) on rust-lang#13158. - Fix rust-lang#13158 ## Solution Previously the lint had an exception for all instances of a stable item in an unstable module, primarily to allow certain intrinsics such as `copy` to be accessible. Instead, I check for the presence of `rustc_allowed_through_unstable_modules` to handle those exceptions, and allow the `is_stable` check within the lint to early out as soon as any part of its path is unstable. I believe this was the last piece required to resolve rust-lang#13158, and have added tests for all examples listed in the issue. If there are other examples of this lint failing, I'd greatly appreciate seeing them! --- ## Notes - No AI tooling of any kind was used during the creation of this PR. - Originally opened (in error) as rust-lang/rust#156164 --- *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: fix certain false positives for [`std_instead_of_core`] for stable items in an unstable module (e.g., `core::io::ErrorKind`), and other MSRV-unaware issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
std_instead_of_corerust-clippy#13158.Solution
Previously the lint had an exception for all instances of a stable item in an unstable module, primarily to allow certain intrinsics such as
copyto be accessible. Instead, I check for the presence ofrustc_allowed_through_unstable_modulesto handle those exceptions, and allow theis_stablecheck within the lint to early out as soon as any part of its path is unstable.Notes