enabling instrumentation for stage 3 compilers#157930
Open
nobellium1997 wants to merge 1 commit into
Open
Conversation
This commit allows users to instrument their stage 3 compilers.
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Hi, could you say more about the use-case please? (the change looks simple enough though) |
Member
|
I'm curious to hear more on ^ as well, but the change itself seems reasonable indeed. |
Author
|
许杰友 Jieyou Xu (Joe) ***@***.***> writes:
jieyouxu left a comment (rust-lang/rust#157930)
I'm curious to hear more on ^ as well, but the change itself seems
reasonable indeed.
--
Reply to this email directly or view it on GitHub:
#157930 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
Hi sorry honestly I'm trying to figure out why we instrument the stage 3
compiler myself. Our optimization pipeline is quite complex so it's
taking me a while to understand it.
I think for now we can simply un-assign this PR while I try to
understand things better.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows users to instrument their stage 3 compilers.
This PR is a revival of the following PR: #101744
The aim is to break up the PR into smaller chunks and merge these changes in piecemeal. The PR here is to allow us to instrument stage 3 rust compilers as stage 3 instrumentation is part of how we create profiles for guided optimization later on.