Use the target checking infrastructure for the diagnostic attributes#158178
Merged
Conversation
Collaborator
|
Some changes occurred to diagnostic attributes. cc @mejrs Some changes occurred in compiler/rustc_attr_parsing |
1d94108 to
9e09aee
Compare
mejrs
approved these changes
Jun 21, 2026
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 21, 2026
Use the target checking infrastructure for the diagnostic attributes The goal of this is a few things: * Make the diagnostic attributes' target checking cleaner and more declarative, making it harder to make mistakes here * Make progress towards removing the `ALL_TARGETS` list r? @mejrs
This was referenced Jun 21, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 21, 2026
…uwer Rollup of 9 pull requests Successful merges: - #156356 (bootstrap: add bootstrap step to run intrinsic-test in CI) - #157711 (Move proc-macro dlopen from proc-macro-srv to rustc_metadata) - #157836 (rebuild LLVM when `bootstrap.toml` config changes) - #158214 (Don't try to remove assignments in SimplifyComparisonIntegral) - #158226 (miri subtree update) - #158108 (Update actions/download-artifact action to v8.0.1) - #158150 (Update backtrace submodule to pick up AIX related fixes.) - #158178 (Use the target checking infrastructure for the diagnostic attributes) - #158195 (Add me to some rotation groups)
rust-timer
added a commit
that referenced
this pull request
Jun 22, 2026
Rollup merge of #158178 - JonathanBrouwer:diag_target, r=mejrs Use the target checking infrastructure for the diagnostic attributes The goal of this is a few things: * Make the diagnostic attributes' target checking cleaner and more declarative, making it harder to make mistakes here * Make progress towards removing the `ALL_TARGETS` list r? @mejrs
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jun 22, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#156356 (bootstrap: add bootstrap step to run intrinsic-test in CI) - rust-lang/rust#157711 (Move proc-macro dlopen from proc-macro-srv to rustc_metadata) - rust-lang/rust#157836 (rebuild LLVM when `bootstrap.toml` config changes) - rust-lang/rust#158214 (Don't try to remove assignments in SimplifyComparisonIntegral) - rust-lang/rust#158226 (miri subtree update) - rust-lang/rust#158108 (Update actions/download-artifact action to v8.0.1) - rust-lang/rust#158150 (Update backtrace submodule to pick up AIX related fixes.) - rust-lang/rust#158178 (Use the target checking infrastructure for the diagnostic attributes) - rust-lang/rust#158195 (Add me to some rotation groups)
pull Bot
pushed a commit
to p-avital/rust-analyzer
that referenced
this pull request
Jun 22, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#156356 (bootstrap: add bootstrap step to run intrinsic-test in CI) - rust-lang/rust#157711 (Move proc-macro dlopen from proc-macro-srv to rustc_metadata) - rust-lang/rust#157836 (rebuild LLVM when `bootstrap.toml` config changes) - rust-lang/rust#158214 (Don't try to remove assignments in SimplifyComparisonIntegral) - rust-lang/rust#158226 (miri subtree update) - rust-lang/rust#158108 (Update actions/download-artifact action to v8.0.1) - rust-lang/rust#158150 (Update backtrace submodule to pick up AIX related fixes.) - rust-lang/rust#158178 (Use the target checking infrastructure for the diagnostic attributes) - rust-lang/rust#158195 (Add me to some rotation groups)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this is a few things:
ALL_TARGETSlistr? @mejrs