Skip to content

std: regression test for Windows junction_point stack buffer overflow#158201

Closed
devnexen wants to merge 1 commit into
rust-lang:mainfrom
devnexen:junction_point_overflow_test
Closed

std: regression test for Windows junction_point stack buffer overflow#158201
devnexen wants to merge 1 commit into
rust-lang:mainfrom
devnexen:junction_point_overflow_test

Conversation

@devnexen

Copy link
Copy Markdown
Contributor

Temporary CI-verification test for #158147. Without the fix, a >16 KiB junction target passes the old > u16::MAX length check yet overflows the inline reparse stack buffer. This test must fail on master and pass once the fix lands.

Temporary CI-verification test for rust-lang#158147. Without the fix,
a >16 KiB junction target passes the old `> u16::MAX` length check yet
overflows the inline reparse stack buffer. This test must fail on master
and pass once the fix lands.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 21, 2026
@rustbot

rustbot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 12 candidates
  • Random selection from Darksonn, Mark-Simulacrum, clarfonthey, jhpratt, joboet

@rustbot

rustbot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@Darksonn

Copy link
Copy Markdown
Member

r? @Darksonn

@rustbot rustbot assigned Darksonn and unassigned joboet Jun 21, 2026
@Darksonn

Copy link
Copy Markdown
Member

@bors try

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 21, 2026
std: regression test for Windows junction_point stack buffer overflow
@ChrisDenton

Copy link
Copy Markdown
Member

By default @bors try only tests linux. To test windows you need to select the jobs to run. See the dev guide's section on try builds.

@bors try jobs=x86_64-msvc-1,x86_64-msvc-2

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 21, 2026
std: regression test for Windows junction_point stack buffer overflow


try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@Darksonn

Copy link
Copy Markdown
Member

Ah, thanks.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test fs::tests::invalid_path_raises ... ok
error: test failed, to rerun pass `-p std --lib`

Caused by:
  process didn't exit successfully: `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-std\x86_64-pc-windows-msvc\dist\deps\std-409e131965b35c7e.exe -Z unstable-options --format json` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)
note: test exited abnormally; to see the full output pass --no-capture to the harness.
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Build completed unsuccessfully in 1:59:34
make: *** [Makefile:115: ci-msvc-py] Error 1
  local time: Sun Jun 21 11:16:25 CUT 2026
  network time: Sun, 21 Jun 2026 11:16:25 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

@devnexen

Copy link
Copy Markdown
Contributor Author

Can I close it ?

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2026
@rust-bors

rust-bors Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 4b1b77e failed: CI. Failed job:

@Darksonn

Copy link
Copy Markdown
Member

Thanks!

@Darksonn Darksonn closed this Jun 21, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants