Rework lint pass running by nnethercote · Pull Request #158239 · rust-lang/rust

nnethercote · 2026-06-22T06:23:42Z

Some cleanups relating to the running of lint passes.

It's a bad name: long, and contains a negative. `skippable_lints` is better.

In particular, `late_lint_mod` doesn't filter consistently: it only checks if `builtin_lints` needs running in the `passes.is_empty()` case, and it doesn't check if the other passes need running at all.

It's called in two cases: pre-expansion lists, and early lints. The appropriate builtin pass is specified at the call site but the appropriate other passes are chosen within, which is inconsistent. This commit changes it so everything is chosen within, based on the boolean `pre_expansion_lint` parameter. `check_ast_node_inner` is split into `run_passes` and `run_pass`; the extra function is needed because the genericness of `builtin_lints` is pushed down one level below `check_ast_node`.

rustbot · 2026-06-22T06:23:45Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

Urgau · 2026-06-22T07:35:27Z

@bors try @rust-timer queue

Rework lint pass running

rust-bors · 2026-06-22T09:48:17Z

☀️ Try build successful (CI)
Build commit: 9309619 (9309619fbed6f684597cb21e4d42b3451eadf882)
Base parent: 942ac9c (942ac9ce4116d4ea784c9882659372b34978b1f8)

rust-timer · 2026-06-22T10:29:15Z

Finished benchmarking commit (9309619): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.9%, -0.1%]	23
Improvements ✅ (secondary)	-0.5%	[-1.0%, -0.2%]	34
All ❌✅ (primary)	-0.3%	[-0.9%, -0.1%]	23

Max RSS (memory usage)

Results (secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-4.3%, -3.4%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 512.761s -> 504.991s (-1.52%)
Artifact size: 353.08 MiB -> 353.62 MiB (0.15%)

nnethercote · 2026-06-22T22:12:41Z

I have added a new commit renaming pass_must_run as is_lint_pass_required.

Urgau

Looks good to me.

View changes since this review

Urgau · 2026-06-23T05:32:02Z

@bors r+

rust-bors · 2026-06-23T05:32:04Z

📌 Commit 2724e23 has been approved by Urgau

It is now in the queue for this repository.

jhpratt · 2026-06-23T05:41:58Z

@bors p=6

threading between rollups

rust-bors · 2026-06-24T00:09:37Z

💔 Test for e70076a failed: CI. Failed job:

auto - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

jhpratt · 2026-06-24T00:16:30Z

no apparent cause

@bors retry

@Urgau

Rework lint pass running Some cleanups relating to the running of lint passes. r? @Urgau

rust-bors · 2026-06-24T01:23:14Z

💔 Test for 6913ee1 failed: CI. Failed jobs:

auto - x86_64-gnu-aux (web logs, enhanced plaintext logs)
auto - x86_64-gnu-stable (web logs, enhanced plaintext logs)

jhpratt · 2026-06-24T01:45:50Z

@bors retry

jhpratt · 2026-06-24T01:49:40Z

Giving this a shot while I figure out the rollup situation

@bors p=5

@Urgau

Rework lint pass running Some cleanups relating to the running of lint passes. r? @Urgau

rust-bors · 2026-06-24T01:56:58Z

💔 Test for e04e764 failed: CI. Failed job:

auto - x86_64-msvc-ext2 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-06-24T01:59:58Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  RUST_CI_OVERRIDE_RELEASE_CHANNEL: stable
  TOOLSTATE_PUBLISH: 1
##[endgroup]
    Updating crates.io index
error: failed to get `idna_adapter` as a dependency of package `idna v1.0.3`
    ... which satisfies dependency `idna = "^1.0"` of package `cookie_store v0.21.1`
    ... which satisfies dependency `cookie_store = "^0.21.1"` of package `ureq v3.0.8`
    ... which satisfies dependency `ureq = "^3"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `idna_adapter`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of id/na/idna_adapter failed

Caused by:
  curl failed

Caused by:

jhpratt · 2026-06-24T02:01:02Z

@bors p=0

@bors retry

JonathanBrouwer · 2026-06-24T02:21:56Z

@bors p=6
Scheduling this before the next rollup

rust-bors · 2026-06-24T02:22:35Z

⌛ Testing commit 2724e23 with merge a9a3722...

Workflow: https://github.com/rust-lang/rust/actions/runs/28070770324

@Urgau

Rework lint pass running Some cleanups relating to the running of lint passes. r? @Urgau

rust-log-analyzer · 2026-06-24T02:46:18Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  NO_DOWNLOAD_CI_LLVM: 1
  WIX: /d/a/rust/rust/wix
##[endgroup]
    Updating crates.io index
error: failed to get `synstructure` as a dependency of package `yoke-derive v0.7.5`
    ... which satisfies dependency `yoke-derive = "^0.7.5"` of package `yoke v0.7.5`
    ... which satisfies dependency `yoke = "^0.7.4"` of package `icu_collections v1.5.0`
    ... which satisfies dependency `icu_collections = "~1.5.0"` of package `icu_normalizer v1.5.0`
    ... which satisfies dependency `icu_normalizer = "^1.4.3"` of package `idna_adapter v1.2.0`
    ... which satisfies dependency `idna_adapter = "^1"` of package `idna v1.0.3`
    ... which satisfies dependency `idna = "^1.0"` of package `cookie_store v0.21.1`
    ... which satisfies dependency `cookie_store = "^0.21.1"` of package `ureq v3.0.8`
    ... which satisfies dependency `ureq = "^3"` of package `citool v0.1.0 (D:\a\rust\rust\src\ci\citool)`

Caused by:
  failed to load source for dependency `synstructure`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of sy/ns/synstructure failed

Caused by:
  curl failed

Caused by:

jhpratt · 2026-06-24T02:48:42Z

@bors p=0

@bors retry

There's a stable backport and a very large rollup that should go before this imo

rust-bors · 2026-06-24T02:48:45Z

❗ You can only retry pull requests that are approved and have a previously failed auto build.

Hint: There is currently a pending auto build on this PR. To cancel it, run @bors cancel.

jhpratt · 2026-06-24T02:49:15Z

Ugh rust-log-analyzer fooled me again

nnethercote added 5 commits June 22, 2026 16:03

Remove unnecessary parens

5ecda6e

Factor out repeated "run pass?" code

f5cba18

Rename lints_that_dont_need_to_run

b06c311

It's a bad name: long, and contains a negative. `skippable_lints` is better.

Make late_lint_mod/late_lint_crate more similar

8f412c4

In particular, `late_lint_mod` doesn't filter consistently: it only checks if `builtin_lints` needs running in the `passes.is_empty()` case, and it doesn't check if the other passes need running at all.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2026

rustbot assigned Urgau Jun 22, 2026

Urgau reviewed Jun 22, 2026

View reviewed changes

Comment thread compiler/rustc_lint/src/lib.rs Outdated