Stop excluding stdarch test crates from rust-src#158336
Open
CathalMullan wants to merge 1 commit into
Open
Conversation
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup=iffy Hm, those ~12MB we'd get by dropping the data after unpacking would be nice, but I think we can take the current step for now -- seems broadly harmless. I wonder if the implication there is that intrinsics_data should store compressed copies of the data, rather than keeping the raw contents in the repository? Or at least support using a compressed form (in which case we could compress in bootstrap for example)? Most users would probably be happier with that disk space use (and it's probably a bit faster to write to disk as well). r? me |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 24, 2026
…Simulacrum Stop excluding `stdarch` test crates from `rust-src` In the past, this exclusion saved 30MB of heavy intrinsics data from ending up in `rust-src`. However, this filter has been outdated since rust-lang/stdarch#1894, which moved the data to `library/stdarch/intrinsics_data`. These intrinsics have also shrunk since then, and now sit around 12MB (300KB when compressed). So this specific change only adds a few KBs: | `rust-src` | compressed | unpacked | | ---------- | ---------- | -------- | | before | 8.01 MB | 76.5 MB | | after | 8.06 MB | 76.9 MB | The motivation for this change would be simplifying integration of the `stdarch` test suite into `cg_clif`. For completeness, if we instead fixed the filter to point to the new data location, we'd shrink the dist to: | `rust-src` | compressed | unpacked | | ---------- | ---------- | -------- | | filtered | 7.64 MB | 64.7 MB | cc @bjorn3
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 24, 2026
…Simulacrum Stop excluding `stdarch` test crates from `rust-src` In the past, this exclusion saved 30MB of heavy intrinsics data from ending up in `rust-src`. However, this filter has been outdated since rust-lang/stdarch#1894, which moved the data to `library/stdarch/intrinsics_data`. These intrinsics have also shrunk since then, and now sit around 12MB (300KB when compressed). So this specific change only adds a few KBs: | `rust-src` | compressed | unpacked | | ---------- | ---------- | -------- | | before | 8.01 MB | 76.5 MB | | after | 8.06 MB | 76.9 MB | The motivation for this change would be simplifying integration of the `stdarch` test suite into `cg_clif`. For completeness, if we instead fixed the filter to point to the new data location, we'd shrink the dist to: | `rust-src` | compressed | unpacked | | ---------- | ---------- | -------- | | filtered | 7.64 MB | 64.7 MB | cc @bjorn3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past, this exclusion saved 30MB of heavy intrinsics data from ending up in
rust-src. However, this filter has been outdated since rust-lang/stdarch#1894, which moved the data tolibrary/stdarch/intrinsics_data. These intrinsics have also shrunk since then, and now sit around 12MB (300KB when compressed).So this specific change only adds a few KBs:
rust-srcThe motivation for this change would be simplifying integration of the
stdarchtest suite intocg_clif.For completeness, if we instead fixed the filter to point to the new data location, we'd shrink the dist to:
rust-srccc @bjorn3