Skip to content

librustc_trans: Handle DST structs in trans::_match.#25060

Merged
bors merged 1 commit into
rust-lang:masterfrom
luqmana:matching-dst-struct
May 3, 2015
Merged

librustc_trans: Handle DST structs in trans::_match.#25060
bors merged 1 commit into
rust-lang:masterfrom
luqmana:matching-dst-struct

Conversation

@luqmana

@luqmana luqmana commented May 2, 2015

Copy link
Copy Markdown
Contributor

Fixes #23261.

cc @blaenk

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@huonw

huonw commented May 3, 2015

Copy link
Copy Markdown
Contributor

Does this handle trait objects?

@luqmana

luqmana commented May 3, 2015

Copy link
Copy Markdown
Contributor Author

@huonw Yes, it should. Let me update the test case.

@luqmana luqmana force-pushed the matching-dst-struct branch 2 times, most recently from f87a986 to 6a46b86 Compare May 3, 2015 03:53
Comment thread src/librustc_trans/trans/_match.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment about the - 1?

@huonw

huonw commented May 3, 2015

Copy link
Copy Markdown
Contributor

r=me with an explanatory comment

@luqmana luqmana force-pushed the matching-dst-struct branch from 6a46b86 to 715605f Compare May 3, 2015 09:36
@luqmana

luqmana commented May 3, 2015

Copy link
Copy Markdown
Contributor Author

@bors r=huonw

@bors

bors commented May 3, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 715605f has been approved by huonw

@bors

bors commented May 3, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 715605f with merge 6b3d66b...

bors added a commit that referenced this pull request May 3, 2015
@bors

bors commented May 3, 2015

Copy link
Copy Markdown
Collaborator

@bors bors merged commit 715605f into rust-lang:master May 3, 2015
@blaenk

blaenk commented May 3, 2015

Copy link
Copy Markdown
Contributor

Great job @luqmana 👍

@luqmana luqmana deleted the matching-dst-struct branch May 4, 2015 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE when matching on DST structs.

5 participants