Skip to content

Document std::env::const values#25668

Merged
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:doc_const
May 27, 2015
Merged

Document std::env::const values#25668
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:doc_const

Conversation

@steveklabnik

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Comment thread src/libstd/env.rs

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing something for windows?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, that was the last line of my git grep, accidentally deleted it

@bluss

bluss commented May 21, 2015

Copy link
Copy Markdown
Contributor

Should we say that the set of possible values can change (grow) in the future?

@steveklabnik

Copy link
Copy Markdown
Contributor Author

That's always true of a non-enum, though.

@alexcrichton

Copy link
Copy Markdown
Member

Looks good to me, thanks @steveklabnik! I agree with @bluss though that the phrasing may want to indicate that it's not an exhaustive list (e.g. I don't want a bug to be opened saying that the documentation disagrees with the implementation). Perhaps something like "Some possible values:" in the sense that the "Some" indicates that this is just a subset.

@alexcrichton

Copy link
Copy Markdown
Member

Other than that though r=me

@nikomatsakis

Copy link
Copy Markdown
Contributor

r? @alexcrichton

@steveklabnik

Copy link
Copy Markdown
Contributor Author

@bors: r=alexcrichton rollup

@bors

bors commented May 26, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 04c7b82 has been approved by alexcrichton

Comment thread src/libstd/env.rs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a leftover? I don't think this documentation is Linux-specific.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is currently built on Linux, and so all of these examples have something like this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file generated by some script? Otherwise this should probably be changed.

Manishearth added a commit to Manishearth/rust that referenced this pull request May 27, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request May 27, 2015
bors added a commit that referenced this pull request May 27, 2015
@bors bors merged commit 04c7b82 into rust-lang:master May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants