Skip to content

Contributing guide should explain the issue tracker tags#25832

Merged
bors merged 1 commit into
rust-lang:masterfrom
edunham:document-gh-issue-tags
May 29, 2015
Merged

Contributing guide should explain the issue tracker tags#25832
bors merged 1 commit into
rust-lang:masterfrom
edunham:document-gh-issue-tags

Conversation

@edunham

@edunham edunham commented May 27, 2015

Copy link
Copy Markdown
Contributor

I took a guess at what they mean, but could be totally wrong. Please comment, and I'll update the PR with corrections!

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here there's a few multiple levels within the E group itself, for example E-hard is a thing but E-easy definitely means easy. I'm... not sure what the E stands for!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, E- seems to categorize difficulty, but I'm not sure what a relevant mneumonic for that would be. Exigency status, perhaps? Or just "Easiness"?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose D may have been a better prefix... perhaps "experience"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experience?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's experience

Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The A is actually for the "area" of the project it's in.

@alexcrichton

Copy link
Copy Markdown
Member

Looks good to me! r=me with a squash

@brson

brson commented May 28, 2015

Copy link
Copy Markdown
Contributor

I'm about to delete A-an-interesting-project and rename I-regression to I-stable-regression.

A discussion at #25832 established what
the abbreviations mean.
@edunham

edunham commented May 28, 2015

Copy link
Copy Markdown
Contributor Author

Amended the squashed commit to remove mention of A-an-interesting-project. It never specifically discussed I-stable-regression. Thanks for the heads up that those are changing!

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 177531e

@alexcrichton

Copy link
Copy Markdown
Member

@bors: rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 29, 2015
…lexcrichton

I took a guess at what they mean, but could be totally wrong. Please comment, and I'll update the PR with corrections!
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 29, 2015
…lexcrichton

I took a guess at what they mean, but could be totally wrong. Please comment, and I'll update the PR with corrections!
@bors

bors commented May 29, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 177531e with merge 42a59ae...

bors added a commit that referenced this pull request May 29, 2015
I took a guess at what they mean, but could be totally wrong. Please comment, and I'll update the PR with corrections!
@bors

bors commented May 29, 2015

Copy link
Copy Markdown
Collaborator

@bors bors merged commit 177531e into rust-lang:master May 29, 2015
XMPPwocky pushed a commit to XMPPwocky/rust that referenced this pull request May 29, 2015
A discussion at rust-lang#25832 established what
the abbreviations mean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants