Fix issue 31109#31410
Merged
Merged
Conversation
added 5 commits
February 4, 2016 16:24
Using f64's bit size probably wasn't actually *wrong*, but it would overshoot for no reason. This might have slowed down f32 parsing significantly.
…t run by default)
The code there still triggers an ICE, but for different reasons (const eval unwraps the parse result).
… condition was ever added.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
82767ef to
7ffed30
Compare
Ideally float parsing wouldn't fail at all, but for the moment let's give a helpful message. Fixes rust-lang#31109
7ffed30 to
a76cb45
Compare
Contributor
Author
|
Changed to |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit a76cb45 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 6, 2016
Issue #31109 uncovered two semi-related problems: * A panic in `str::parse::<f64>` * A panic in `rustc::middle::const_eval::lit_to_const` where the result of float parsing was unwrapped. This series of commits fixes both issues and also drive-by-fixes some things I noticed while tracking down the parsing panic.
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #31109 uncovered two semi-related problems:
str::parse::<f64>rustc::middle::const_eval::lit_to_constwhere the result of float parsing was unwrapped.This series of commits fixes both issues and also drive-by-fixes some things I noticed while tracking down the parsing panic.