Updated error message E0388

[medzin]

Fixes #35339 as part of #35233.

r? @GuillaumeGomez

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[arielb1]

The error can also be "cannot assign in a static". I think the label should be "bad mutation here".

Also, the label can apply to all the error codes in the function - put it before the help.

[medzin]

@arielb1 So label "bad mutation here" should be applied to error codes from E0385 to E0389?

[sophiajt]

@arielb1 - trying to come up with a good wording. What do you mean by "cannot assign in a static". You can assign to a static, no? What are the cases you can't?

[medzin]

@arielb1 & @jonathandturner So, what should I change? I'm a little confused here.

[arielb1]

I would like the label "invalid mutation here".

[sophiajt]

@medzin - sorry for the confusion!

We ended up chatting (and I also chatted with @nikomatsakis) and he had this suggestion: "cannot write data in a static definition"

Please use this for now. If we need to update it later, we can do it in a different PR.

[medzin]

@jonathandturner Message changed.

[sophiajt]

Sorry for the delay! I forgot I hadn't approved this one.

@bors r+ rollup

[bors]

📌 Commit bb827aa has been approved by jonathandturner

[GuillaumeGomez]

@bors: r-

@medzin: Please squash your commits.

[medzin]

@GuillaumeGomez Done

[GuillaumeGomez]

Thanks!

@bors: r+ rollup

[bors]

📌 Commit bfbdff0 has been approved by GuillaumeGomez

[GuillaumeGomez]

@bors: r-

[GuillaumeGomez]

@bors: r=jonathandturner

[bors]

📌 Commit bfbdff0 has been approved by jonathandturner