Skip to content

travis: Make more network requests retryable #40112

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:fetch-all
Feb 26, 2017
Merged

travis: Make more network requests retryable #40112
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:fetch-all

Conversation

@alexcrichton

@alexcrichton alexcrichton commented Feb 26, 2017

Copy link
Copy Markdown
Member

This commit attempts to move more network operations to being retryable through
various operations. For example git submodule updates, downloading snapshots,
etc, are now all in retryable steps.

Hopefully this commit can cut down on the number of network failures we've been
seeing!

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton changed the title travis: Try to perform network requests in one step travis: Make more network requests retryable Feb 26, 2017
@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: r=brson p=1

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit fc1ac9c has been approved by brson

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fc1ac9c with merge bc62b9b...

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

This commit attempts to move more network operations to being retryable through
various operations. For example git submodule updates, downloading snapshots,
etc, are now all in retryable steps.

Hopefully this commit can cut down on the number of network failures we've been
seeing!
@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: r=brson

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit c08f382 has been approved by brson

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c08f382 with merge 44e9e0a...

bors added a commit that referenced this pull request Feb 26, 2017
 travis: Make more network requests retryable

This commit attempts to move more network operations to being retryable through
various operations. For example git submodule updates, downloading snapshots,
etc, are now all in retryable steps.

Hopefully this commit can cut down on the number of network failures we've been
seeing!
Comment thread src/ci/shared.sh
function retry {
local n=1
local max=5
local delay=15

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable

@bors

bors commented Feb 26, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 44e9e0a to master...

@bors bors merged commit c08f382 into rust-lang:master Feb 26, 2017
@alexcrichton alexcrichton deleted the fetch-all branch March 8, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants