Skip to content

fixed some clippy warnings in libcollections#40541

Closed
llogiq wants to merge 3 commits into
rust-lang:masterfrom
llogiq:clippy-libcollections
Closed

fixed some clippy warnings in libcollections#40541
llogiq wants to merge 3 commits into
rust-lang:masterfrom
llogiq:clippy-libcollections

Conversation

@llogiq

@llogiq llogiq commented Mar 15, 2017

Copy link
Copy Markdown
Contributor

Some markdown fixes, a few readability improvements, but mostly trivial stuff.

@rust-highfive

rust-highfive commented Mar 15, 2017

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson

brson commented Mar 15, 2017

Copy link
Copy Markdown
Contributor

@bors r+ Thanks @llogiq

@bors

bors commented Mar 15, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 70deac1 has been approved by brson

@arielb1 arielb1 mentioned this pull request Mar 18, 2017
Closed
bors added a commit that referenced this pull request Mar 18, 2017
@bors
Auto merge of #40644 - arielb1:rollup, r=arielb1
1d565ef 
Rollup of 22 pull requests

- Successful merges: #40241, #40346, #40348, #40377, #40398, #40409, #40441, #40445, #40509, #40521, #40523, #40532, #40538, #40564, #40581, #40583, #40588, #40589, #40590, #40603, #40611, #40621
- Failed merges: #40501, #40541
@bors

bors commented Mar 19, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #40538) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Mar 25, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #40806) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank

estebank commented Mar 29, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 1cbfdf4 has been approved by estebank

@estebank

estebank commented Mar 29, 2017

Copy link
Copy Markdown
Contributor

@bors r-

@estebank

estebank commented Mar 29, 2017

Copy link
Copy Markdown
Contributor

@bors r=brson

@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 1cbfdf4 has been approved by brson

@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1cbfdf4 with merge d05de67...

@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@alexcrichton

alexcrichton commented Mar 29, 2017

Copy link
Copy Markdown
Member

@bors: retry

@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1cbfdf4 with merge 11deb59...

@bors

bors commented Mar 29, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@estebank

estebank commented Mar 30, 2017

Copy link
Copy Markdown
Contributor

@bors retry

@frewsxcv frewsxcv mentioned this pull request Mar 30, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Mar 30, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Apr 4, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Apr 4, 2017
Closed
@bors

bors commented Apr 5, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1cbfdf4 with merge 7ebc15a...

@bors

bors commented Apr 5, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@frewsxcv

frewsxcv commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

@bors retry

1 similar comment
@frewsxcv

frewsxcv commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Apr 5, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1cbfdf4 with merge 66267b3...

@bors

bors commented Apr 5, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@alexcrichton

alexcrichton commented Apr 5, 2017 via email

Copy link
Copy Markdown
Member

@alexcrichton

alexcrichton commented Apr 5, 2017

Copy link
Copy Markdown
Member

@bors: r-

er, hang on

@alexcrichton

alexcrichton commented Apr 5, 2017

Copy link
Copy Markdown
Member

This PR is always failing with #40906, which makes me think it's not a spurious error. Turns out that's not happening on any other PRs as well. Even if this is just a bug in the MinGW linker, I don't think we can land this PR as-is.

@alexcrichton alexcrichton mentioned this pull request Apr 5, 2017
Closed
@bluss

bluss commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

Scouring through, I can't find anything suspicious in the diff.

@llogiq

llogiq commented Apr 5, 2017

Copy link
Copy Markdown
Contributor Author

I think I may want to bisect this. Pity that travis doesn't show the error. Hang on...

@bluss

bluss commented Apr 5, 2017

Copy link
Copy Markdown
Contributor

Something hiding behind the merge in this branch?

@llogiq

llogiq commented Apr 10, 2017

Copy link
Copy Markdown
Contributor Author

I'm closing this in favor of a series of smaller PRs.

@llogiq llogiq closed this Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tamird tamird tamird left review comments

@bluss bluss bluss left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@brson brson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@llogiq @rust-highfive @brson @bors @estebank @alexcrichton @frewsxcv @bluss @tamird