Skip to content

Improve os::linux documentation (#29367)#40869

Merged
bors merged 1 commit into
rust-lang:masterfrom
ctjhoa:master
Mar 31, 2017
Merged

Improve os::linux documentation (#29367)#40869
bors merged 1 commit into
rust-lang:masterfrom
ctjhoa:master

Conversation

@ctjhoa

@ctjhoa ctjhoa commented Mar 27, 2017

Copy link
Copy Markdown
Contributor

Improve os::linux documentation according to #29367

r? @steveklabnik

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik steveklabnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks! I have one tiny nit and then we can merge.

Comment thread src/libstd/os/linux/fs.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a /// above this line? With markdown, just one \n doesn't actually cause a line break; it will bleed together as one paragraph. We try to usually have a short summary, a blank space, and then elaborate more 😄

@ctjhoa

ctjhoa commented Mar 28, 2017

Copy link
Copy Markdown
Contributor Author

@steveklabnik done

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

awesome, thanks!

@bors

bors commented Mar 28, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 732fe24 has been approved by steveklabnik

@frewsxcv

Copy link
Copy Markdown
Contributor

@bors r-

Looks like there's a tidy error:

/checkout/src/libstd/os/linux/fs.rs:60: line longer than 100 chars

@ctjhoa

ctjhoa commented Mar 31, 2017

Copy link
Copy Markdown
Contributor Author

@frewsxcv @steveklabnik this should be ok.

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

👍

@bors

bors commented Mar 31, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit b36cff5 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 31, 2017
Improve os::linux documentation (rust-lang#29367)

Improve `os::linux` documentation according to rust-lang#29367

r? @steveklabnik
bors added a commit that referenced this pull request Mar 31, 2017
Rollup of 10 pull requests

- Successful merges: #40694, #40842, #40869, #40888, #40898, #40904, #40925, #40928, #40929, #40934
- Failed merges:
@bors bors merged commit b36cff5 into rust-lang:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants