Skip to content

Remove non-breaking spaces from natvis files#41344

Merged
bors merged 1 commit into
rust-lang:masterfrom
Diggsey:remove-natvis-nbsp
Apr 18, 2017
Merged

Remove non-breaking spaces from natvis files#41344
bors merged 1 commit into
rust-lang:masterfrom
Diggsey:remove-natvis-nbsp

Conversation

@Diggsey

@Diggsey Diggsey commented Apr 17, 2017

Copy link
Copy Markdown
Contributor

Visual studio will see natvis files with non-breaking spaces as invalid XML, and will ignore them.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@AndrewGaspar

Copy link
Copy Markdown
Contributor

Thank you for fixing this! I was wondering why they weren't working in VS.

@Diggsey

Diggsey commented Apr 17, 2017

Copy link
Copy Markdown
Contributor Author

@AndrewGaspar Thanks for adding them - they work well except I don't think Option is quite right any more? It's showing a Some(<invalid data>) where it should be showing a None for me.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Apr 18, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 1528cbe has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 18, 2017
…richton

Remove non-breaking spaces from natvis files

Visual studio will see natvis files with non-breaking spaces as invalid XML, and will ignore them.
bors added a commit that referenced this pull request Apr 18, 2017
Rollup of 3 pull requests

- Successful merges: #41262, #41310, #41344
- Failed merges:
@bors

bors commented Apr 18, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #41357) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 1528cbe into rust-lang:master Apr 18, 2017
@Diggsey Diggsey deleted the remove-natvis-nbsp branch December 27, 2017 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants