Allow bare CR in ////-style comment.

[qnighy]

Fixes #40624 in a way that bare CR is allowed in all non-doc comments.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[estebank]

@bors r+ rollup

[bors]

📌 Commit 0e8e45c has been approved by estebank

[nikomatsakis]

@qnighy thanks for the bug fix! But I have a question. I think the more fundamental problem here is that the test for "is this a doc comment" is kind of "open-coded" here. That boolean that you modified might be better called "starts-with-triple-slash" or "is-maybe-doc-comment". If you look a bit later on in the file, you'll see some logic that invokes is_doc_comment() to test whether the comment is really a doc-comment. Do you think you could modify the \r test to use that helper so that things are more DRY?

[qnighy]

@nikomatsakis I've left it undone because scan_block_comment() does the similar thing and I thought it might be on purpose. If not, I will sort it out when I have time.

[nikomatsakis]

@qnighy not that I know of...