Fixup some nits from #44238

[nrc]

r? @ollie27

[nrc]

cc #44229

[ollie27]

Apart from that one error this looks good to me.

[ollie27]

This should be 45 to make sure the resulting string is at most 70 characters.

[nrc]

Addressed this, thanks! I set to 50 (as in the old code), there is no strict need to be under 70 chars, it is just roughly a number that should fit on one line (comfortably under 80 chars).

[ollie27]

Well that's okay but if the line is exactly 71 characters for example then using 50 will skip one character and replace it with " ... " making the string display actually longer. It's only a minor thing though.

[nrc]

ping @ollie27 for re-review

[ollie27]

@bors: r+

[bors]

@ollie27: 🔑 Insufficient privileges: Not in reviewers

[nrc]

@bors: r=ollie27

[bors]

📌 Commit 0573949 has been approved by ollie27

[Mark-Simulacrum]

@bors rollup