Skip to content

Forcibly disable optimizations in backtrace-debuginfo#48090

Closed
alexcrichton wants to merge 1 commit into
rust-lang:masterfrom
alexcrichton:disable-opt-test
Closed

Forcibly disable optimizations in backtrace-debuginfo#48090
alexcrichton wants to merge 1 commit into
rust-lang:masterfrom
alexcrichton:disable-opt-test

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

Various versions of LLVM do various things with debuginfo but we're most curious
that our own code is working so let's just disable optimizations in this test to
ensure we have as much pristine debuginfo as possible.

This is currently extracted from #47828 to land standalone

Various versions of LLVM do various things with debuginfo but we're most curious
that our own code is working so let's just disable optimizations in this test to
ensure we have as much pristine debuginfo as possible.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 9, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit b521c77 has been approved by nikomatsakis

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 9, 2018
@alexcrichton

Copy link
Copy Markdown
Member Author

@bors: rollup

kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018
…komatsakis

Forcibly disable optimizations in backtrace-debuginfo

Various versions of LLVM do various things with debuginfo but we're most curious
that our own code is working so let's just disable optimizations in this test to
ensure we have as much pristine debuginfo as possible.

This is currently extracted from rust-lang#47828 to land standalone
bors added a commit that referenced this pull request Feb 9, 2018
Rollup of 17 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48085, #48086, #48090, #48093, #48098, #48101
- Failed merges:
@kennytm

kennytm commented Feb 10, 2018

Copy link
Copy Markdown
Member

#47828 (which includes this change) has been merged, closing.

@kennytm kennytm closed this Feb 10, 2018
@alexcrichton alexcrichton deleted the disable-opt-test branch June 29, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants