Skip to content

Correct initial field alignment for repr(C)/repr(int)#50354

Merged
bors merged 3 commits into
rust-lang:masterfrom
varkor:initial-field-alignment-c-int
May 2, 2018
Merged

Correct initial field alignment for repr(C)/repr(int)#50354
bors merged 3 commits into
rust-lang:masterfrom
varkor:initial-field-alignment-c-int

Conversation

@varkor

@varkor varkor commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

Fixes #50098 following #50098 (comment).

(I wasn't sure which kind of test was best suited here — I picked run-pass simply because that was convenient, but if codegen is more appropriate, let me know and I'll change it.)

r? @eddyb

@varkor

varkor commented Apr 30, 2018

Copy link
Copy Markdown
Contributor Author

r? @eddyb (@rust-highfive is being negligent...)

@Gankra

Gankra commented May 1, 2018

Copy link
Copy Markdown
Contributor

Could you dupe the test for repr(u8) as well?

@eddyb

eddyb commented May 1, 2018

Copy link
Copy Markdown
Contributor

@varkor You could also add/modify a test in ui/print_type_sizes or those added in #46123.

@varkor varkor force-pushed the initial-field-alignment-c-int branch from 45b2c1f to 4da1f71 Compare May 1, 2018 19:11
@varkor

varkor commented May 1, 2018

Copy link
Copy Markdown
Contributor Author

@gankro: good point!

@eddyb: ah, perfect, that's just what I was looking for.

@eddyb

eddyb commented May 1, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 1, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 2d0d73e has been approved by eddyb

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 1, 2018
@bors

bors commented May 2, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2d0d73e with merge 3eadd75...

bors added a commit that referenced this pull request May 2, 2018
Correct initial field alignment for repr(C)/repr(int)

Fixes #50098 following #50098 (comment).

(I wasn't sure which kind of test was best suited here — I picked run-pass simply because that was convenient, but if codegen is more appropriate, let me know and I'll change it.)

r? @eddyb
@bors

bors commented May 2, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 3eadd75 to master...

@bors bors merged commit 2d0d73e into rust-lang:master May 2, 2018
@varkor varkor deleted the initial-field-alignment-c-int branch May 2, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants