Skip to content

rustdoc: Fix local reexports of proc macros#56637

Merged
bors merged 1 commit into
rust-lang:masterfrom
ollie27:rustdoc_proc_macro_local_reexport
Dec 14, 2018
Merged

rustdoc: Fix local reexports of proc macros#56637
bors merged 1 commit into
rust-lang:masterfrom
ollie27:rustdoc_proc_macro_local_reexport

Conversation

@ollie27

@ollie27 ollie27 commented Dec 8, 2018

Copy link
Copy Markdown
Contributor

Filter out ProcMacroStubs to avoid an ICE during cleaning.

Also add proc macros to cache().paths so it can generate links.

r? @QuietMisdreavus

Filter out `ProcMacroStub`s to avoid an ICE during cleaning.

Also add proc macros to `cache().paths` so it can generate links.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 8, 2018

@QuietMisdreavus QuietMisdreavus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@QuietMisdreavus

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Dec 10, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 0bb075f has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2018
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Dec 11, 2018
…export, r=QuietMisdreavus

rustdoc: Fix local reexports of proc macros

Filter out `ProcMacroStub`s to avoid an ICE during cleaning.

Also add proc macros to `cache().paths` so it can generate links.

r? @QuietMisdreavus
kennytm added a commit to kennytm/rust that referenced this pull request Dec 12, 2018
…export, r=QuietMisdreavus

rustdoc: Fix local reexports of proc macros

Filter out `ProcMacroStub`s to avoid an ICE during cleaning.

Also add proc macros to `cache().paths` so it can generate links.

r? @QuietMisdreavus
kennytm added a commit to kennytm/rust that referenced this pull request Dec 13, 2018
…export, r=QuietMisdreavus

rustdoc: Fix local reexports of proc macros

Filter out `ProcMacroStub`s to avoid an ICE during cleaning.

Also add proc macros to `cache().paths` so it can generate links.

r? @QuietMisdreavus
kennytm added a commit to kennytm/rust that referenced this pull request Dec 14, 2018
…export, r=QuietMisdreavus

rustdoc: Fix local reexports of proc macros

Filter out `ProcMacroStub`s to avoid an ICE during cleaning.

Also add proc macros to `cache().paths` so it can generate links.

r? @QuietMisdreavus
bors added a commit that referenced this pull request Dec 14, 2018
Rollup of 14 pull requests (first batch)

Successful merges:

 - #56562 (Update libc version required by rustc)
 - #56609 (Unconditionally emit the target-cpu LLVM attribute.)
 - #56637 (rustdoc: Fix local reexports of proc macros)
 - #56658 (Add non-panicking `maybe_new_parser_from_file` variant)
 - #56695 (Fix irrefutable matches on integer ranges)
 - #56699 (Use a `newtype_index!` within `Symbol`.)
 - #56702 ([self-profiler] Add column for percent of total time)
 - #56708 (Remove some unnecessary feature gates)
 - #56709 (Remove unneeded extra chars to reduce search-index size)
 - #56744 (specialize: remove Boxes used by Children::insert)
 - #56748 (Update panic message to be clearer about env-vars)
 - #56749 (x86: Add the `adx` target feature to whitelist)
 - #56756 (Disable btree pretty-printers on older gdbs)
 - #56789 (rustc: Add an unstable `simd_select_bitmask` intrinsic)

r? @ghost
@bors bors merged commit 0bb075f into rust-lang:master Dec 14, 2018
@ollie27 ollie27 deleted the rustdoc_proc_macro_local_reexport branch December 17, 2018 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants