Skip to content

borrowck: prefer "value" over "_" in diagnostics#70389

Merged
bors merged 2 commits into
rust-lang:masterfrom
Centril:borrowck-no-underscores
Mar 26, 2020
Merged

borrowck: prefer "value" over "_" in diagnostics#70389
bors merged 2 commits into
rust-lang:masterfrom
Centril:borrowck-no-underscores

Conversation

@Centril

@Centril Centril commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

@Centril Centril added the F-bindings_after_at `#![feature(bindings_after_at)]` label Mar 25, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2020
@Centril

Centril commented Mar 25, 2020

Copy link
Copy Markdown
Contributor Author

Let's try @bors delegate=mark-i-m

@bors

bors commented Mar 25, 2020

Copy link
Copy Markdown
Collaborator

✌️ @mark-i-m can now approve this pull request

mark-i-m
mark-i-m approved these changes Mar 26, 2020
View reviewed changes

@mark-i-m mark-i-m left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Centril Thanks! I left a bunch of minor comments, but I don't think any of them really need to block this PR. Feel free to r=me if you don't want to address them here.

Comment thread src/librustc_mir/borrow_check/diagnostics/mod.rs Outdated
Comment thread src/librustc_mir/borrow_check/diagnostics/mod.rs Outdated
Comment thread src/librustc_mir/util/borrowck_errors.rs Outdated
Comment thread src/librustc_mir/util/borrowck_errors.rs Outdated
Comment thread src/librustc_mir/util/borrowck_errors.rs Outdated
@Centril

Centril commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

Addressed the comments. :)

r? @mark-i-m @bors r=mark-i-m

@bors

bors commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 632c0af has been approved by mark-i-m

@rust-highfive rust-highfive assigned mark-i-m and unassigned pnkfelix Mar 26, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2020
@Centril Centril mentioned this pull request Mar 26, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2020
@bors
Auto merge of rust-lang#70415 - Centril:rollup-1zttfvl, r=Centril
a17dd36 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#69866 (Rename `def_span` to `guess_head_span`)
 - rust-lang#69878 (Tweak chained operators diagnostic)
 - rust-lang#70375 (avoid catching InterpError)
 - rust-lang#70386 (typeck: minor pattern typing improvements)
 - rust-lang#70389 (borrowck: prefer "value" over "`_`" in diagnostics)
 - rust-lang#70395 (Update cargo.)

Failed merges:

r? @ghost
@bors bors merged commit 7db4825 into rust-lang:master Mar 26, 2020
@Centril Centril deleted the borrowck-no-underscores branch March 26, 2020 05:52
@Centril Centril mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mark-i-m mark-i-m mark-i-m approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mark-i-m mark-i-m

Labels

F-bindings_after_at `#![feature(bindings_after_at)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NLL diagnostics for ref mut z @ &mut Some(ref a) uses _ as binding name

5 participants

@Centril @bors @mark-i-m @pnkfelix @rust-highfive