smoke-test for async fn with mir-opt-level=0#71444
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I wouldn't do this for the size tests as those could be affected by other optimizations running. For the smoke tests this seems good though. |
|
The size can be affected by MIR optimizations? |
be87eb1 to
9ea5eed
Compare
|
Okay this does not touch the size tests any more. |
Potentially yeah, at least in the future when we have some more advanced optimizations. |
|
@jonas-schievink any chance you could review this? |
jonas-schievink
left a comment
There was a problem hiding this comment.
Looks good. If you want you can also do this for some of the generator tests for some more diversity. But generally r=me
|
@jonas-schievink like so? |
|
@bors r+ |
|
📌 Commit 3a129df has been approved by |
|
☀️ Test successful - checks-azure |
MIR opt levels heavily influence which MIR transformations run, and we barely test non-default opt levels. I am particularly worried about
async fnlowering and how it might (not) work when the set of preceding MIR passes changes -- see #70073.This adds some basic smoke testing, where at least a few
async fnrun-passtest are ensured to also work with mir-opt-level=0.