Skip to content

CI: Workaround MSYS2 issue#72332

Merged
bors merged 1 commit into
rust-lang:masterfrom
mati865:ci-fix
May 18, 2020
Merged

CI: Workaround MSYS2 issue#72332
bors merged 1 commit into
rust-lang:masterfrom
mati865:ci-fix

Conversation

@mati865

@mati865 mati865 commented May 18, 2020

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

rust-highfive commented May 18, 2020

Copy link
Copy Markdown
Contributor

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2020
@mati865

mati865 commented May 18, 2020

Copy link
Copy Markdown
Member Author

r? @ghost

@mati865 mati865 force-pushed the ci-fix branch 2 times, most recently from 3868d1f to 5941007 Compare May 18, 2020 18:07
@mati865 mati865 mentioned this pull request May 18, 2020
Merged
@mati865 mati865 changed the title Try to fix CI CI: Workaround MSYS2 issue May 18, 2020
@mati865 mati865 marked this pull request as ready for review May 18, 2020 18:19
@mati865

mati865 commented May 18, 2020

Copy link
Copy Markdown
Member Author

Old build is no longer available but it successfully installed MSYS2 and it's packages.

Ready for review.

@emilyalbini

emilyalbini commented May 18, 2020

Copy link
Copy Markdown
Member

@bors r+ p=100

Can you also open an issue that asks to revert this once the outage is fixed?

@bors

bors commented May 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f5ae4d5c8a71e118246c2b65bf6a9133bae96236 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2020
@emilyalbini

emilyalbini commented May 18, 2020

Copy link
Copy Markdown
Member

@bors delegate+

@bors

bors commented May 18, 2020

Copy link
Copy Markdown
Collaborator

✌️ @mati865 can now approve this pull request

@mati865

mati865 commented May 18, 2020

Copy link
Copy Markdown
Member Author

Can you also open an issue that asks to revert this once the outage is fixed?

Sure.

You will probably want to retry #67759 because MSYS2 install there failed already.

@bors

bors commented May 18, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f5ae4d5c8a71e118246c2b65bf6a9133bae96236 with merge 913c607aeb0a0b77d8615039c5bc42cddaf4446f...

@bors

bors commented May 18, 2020

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2020
@emilyalbini

emilyalbini commented May 18, 2020

Copy link
Copy Markdown
Member

@bors p=1000

@mati865

mati865 commented May 18, 2020

Copy link
Copy Markdown
Member Author

Tried to be too fancy...

@bors r=pietroalbini

@bors

bors commented May 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 081daf6 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2020
@bors

bors commented May 18, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 081daf6 with merge d887886...

@mati865 mati865 mentioned this pull request May 18, 2020
Closed
@bors

bors commented May 18, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: pietroalbini
Pushing d887886 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 18, 2020
@bors bors merged commit d887886 into rust-lang:master May 18, 2020
@mati865 mati865 deleted the ci-fix branch May 18, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kennytm kennytm

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mati865 @rust-highfive @emilyalbini @bors @kennytm