Revert "Remove optimization_fuel_crate from Session"#88748
Conversation
This reverts commit 5464b2e.
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit 1022646 with merge 74f6fa827dfc2894e627fea79cf03f0927c74911... |
wesleywiser
left a comment
There was a problem hiding this comment.
r=me if the perf looks good
|
☀️ Try build successful - checks-actions |
|
Queued 74f6fa827dfc2894e627fea79cf03f0927c74911 with parent 434cb43, future comparison URL. |
|
Finished benchmarking commit (74f6fa827dfc2894e627fea79cf03f0927c74911): comparison url. Summary: This change led to large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
|
This fixes the worst of the perf regression, but not completely. @bors r=wesleywiser |
|
📌 Commit 1022646 has been approved by |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (02a57fa): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
|
Why didn't this result in a perf improvement after all? |
This reverts commit 5464b2e.
This hopefully fixes the perf regression in #88530 (comment).