Bump rmeta version to fix rustc_serialize ICE#91715
Merged
Merged
Conversation
rust-lang#91407 changed the serialization format which leads to ICEs for nightly users such as rust-lang#91663 and linked issue. Bumping the metadata version should lead to the cached files being discarded instead.
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
Member
|
It would be nice if rustc could still read the old version for better error messages. |
Member
|
@bors p=1 because we've had a couple of tickets already about the assertion |
Contributor
|
Do we know why the rustc version check isn't preventing this from happening? My understanding of the metadata decoding is that it just loads a [u8] and doesn't try to decode unless the header matches (though I may be mis-remembering that). |
Member
Author
|
The incremental format writes out its header as |
Member
|
@bors r+ p=1 I think this can get merged in the meantime, but we should likely followup with a change to rmeta to match incremental's storage of the version. |
Collaborator
|
📌 Commit 0696e79 has been approved by |
Collaborator
|
⌛ Testing commit 0696e79 with merge d2798a1bd28d1ddcae011bb7b03c8f553df7c044... |
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
Member
Author
Collaborator
|
⌛ Testing commit 0696e79 with merge 086ad3b5d4a5499271f84fcd5713fbd7324f029f... |
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
Contributor
|
The aarch64-gnu runner is not starting. @bors retry treeclosed=100 |
This was referenced Dec 10, 2021
Contributor
|
@bors treeclosed- |
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
Contributor
|
@bors retry x86_64-apple has no logs |
Collaborator
|
⌛ Testing commit 0696e79 with merge 4ce3ebb287dae13a8c66f57cde934e3e061ef36c... |
Collaborator
|
💔 Test failed - checks-actions |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
Linking failure @bors retry spurious linking failure |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (82575a1): comparison url. Summary: This change led to very large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Member
Author
|
That result looks bogus, most likely incremental verification noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#91407 changed the serialization format which leads to ICEs for nightly users such as #91663 and linked issues. The issue can be solved by running
cargo clean. But bumping the metadata version should lead to the cached files being discarded, avoiding the issue entirely.