Upgrade indexmap and thorin-dwp to use hashbrown 0.12 by cuviper · Pull Request #99251 · rust-lang/rust

cuviper · 2022-07-14T17:22:20Z

This removes the last dependencies on hashbrown 0.11.

This also upgrades to hashbrown 0.12.3 to fix a double-free (#99372).

rustbot · 2022-07-14T17:22:23Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

rust-highfive · 2022-07-14T17:22:23Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

lqd · 2022-07-15T07:14:24Z

just the usual sanity check:

@bors try @rust-timer queue

rust-timer · 2022-07-15T07:14:25Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-15T07:14:33Z

⌛ Trying commit 8dece5c37a154df71fc5ddbe971d975f9b70e610 with merge 1d7eef78297735725da8f0383f19fcb93167f60d...

bors · 2022-07-15T09:08:41Z

☀️ Try build successful - checks-actions
Build commit: 1d7eef78297735725da8f0383f19fcb93167f60d (1d7eef78297735725da8f0383f19fcb93167f60d)

rust-timer · 2022-07-15T09:08:43Z

Queued 1d7eef78297735725da8f0383f19fcb93167f60d with parent b90a0ed, future comparison URL.

rust-timer · 2022-07-15T11:30:06Z

Finished benchmarking commit (1d7eef78297735725da8f0383f19fcb93167f60d): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.0%	1.0%	2
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-3.2%	-4.0%	2
Improvements 🎉 (secondary)	-3.5%	-3.5%	1
All 😿🎉 (primary)	-3.2%	-4.0%	2

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.5%	-2.5%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

lqd · 2022-07-15T11:43:28Z

looks like usual ctfe-stress-5 noise.

r=me rollup=never if you agree

Mark-Simulacrum · 2022-07-15T11:46:29Z

@bors r+

Yeah, seems like it. Nice improvement in bootstrap times as well!

bors · 2022-07-15T11:46:30Z

📌 Commit 8dece5c37a154df71fc5ddbe971d975f9b70e610 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

lqd · 2022-07-15T11:56:17Z

Indeed, the object speedup is great!

This removes the last dependencies on hashbrown 0.11.

This fixes a double-free in the `clone_from` function if dropping an existing element in the table panics. See rust-lang/hashbrown#348 for more details.

Mark-Simulacrum · 2022-07-23T20:37:37Z

@bors r+ rollup=never

@Amanieu Do we have a reference for when the double-drop was introduced into hashbrown? I would've expected to see that in the changelog entry (https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md#v0123---2022-07-17), at least, but it doesn't seem to be there. Has it always been there?

bors · 2022-07-23T20:37:39Z

📌 Commit 931a8f8 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Amanieu · 2022-07-23T22:30:23Z

I think it's always been there.

bors · 2022-07-24T04:03:34Z

⌛ Testing commit 931a8f8 with merge 4dbc89d...

bors · 2022-07-24T06:46:13Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 4dbc89d to master...

rust-timer · 2022-07-24T08:02:47Z

Finished benchmarking commit (4dbc89d): comparison url.

Instruction count

Primary benchmarks: mixed results
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	0.2%	0.2%	3
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.4%	-0.5%	7
Improvements 🎉 (secondary)	-1.4%	-1.4%	2
All 😿🎉 (primary)	-0.2%	-0.5%	10

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-8.1%	-8.1%	1
Improvements 🎉 (secondary)	-2.6%	-2.6%	1
All 😿🎉 (primary)	-8.1%	-8.1%	1

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	4.5%	4.5%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.9%	-2.9%	1
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

Mark-Simulacrum · 2022-07-24T16:35:19Z

beta-nominating this PR; this addresses a soundness problem in hashbrown (double-free in clone_from) which seems good to roll out to stable on a faster schedule.

…crum Upgrade indexmap and thorin-dwp to use hashbrown 0.12 This removes the last dependencies on hashbrown 0.11. This also upgrades to hashbrown 0.12.3 to fix a double-free (rust-lang#99372).

apiraino · 2022-07-28T14:14:57Z

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

…mulacrum [beta] Rollup of beta backports Includes the following PRs: * rustc-docs: Be less specific about the representation of +bundle rust-lang#100074 * Fix backwards-compatibility check for tests with +whole-archive rust-lang#100068 * Revert write! and writeln! to late drop temporaries rust-lang#99689 * Upgrade indexmap and thorin-dwp to use hashbrown 0.12 rust-lang#99251 * rustdoc: avoid inlining modules with duplicate names rust-lang#99738 r? `@ghost`

rust-highfive assigned Mark-Simulacrum Jul 14, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 14, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2022

cuviper mentioned this pull request Jul 14, 2022

Upgrade hashbrown, indexmap, and object rust-lang/thorin#17

Merged

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 15, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 15, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2022

klensy mentioned this pull request Jul 17, 2022

Upgrade hashbrown to 0.12.3 #99372

Closed

cuviper and others added 2 commits July 17, 2022 07:05

Upgrade indexmap and thorin-dwp to use hashbrown 0.12

daa7c14

This removes the last dependencies on hashbrown 0.11.

Upgrade hashbrown to 0.12.3

931a8f8

This fixes a double-free in the `clone_from` function if dropping an existing element in the table panics. See rust-lang/hashbrown#348 for more details.

cuviper force-pushed the hashbrown-0.12 branch from 8dece5c to 931a8f8 Compare July 17, 2022 14:09

Mark-Simulacrum added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 23, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 24, 2022

bors merged commit 4dbc89d into rust-lang:master Jul 24, 2022

rustbot added this to the 1.64.0 milestone Jul 24, 2022

bors mentioned this pull request Jul 24, 2022

std: use block_current_task for thread parking on Hermit #98534

Closed

rustbot added the perf-regression Performance regression. label Jul 24, 2022

Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 24, 2022

apiraino added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 28, 2022

Mark-Simulacrum modified the milestones: 1.64.0, 1.63.0 Aug 5, 2022

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 5, 2022

Mark-Simulacrum mentioned this pull request Aug 5, 2022

[beta] Rollup of beta backports #100171

Merged

cuviper deleted the hashbrown-0.12 branch October 15, 2022 00:15

Uh oh!

Conversation

cuviper commented Jul 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 14, 2022

Uh oh!

rust-highfive commented Jul 14, 2022

Uh oh!

lqd commented Jul 15, 2022

Uh oh!

rust-timer commented Jul 15, 2022

Uh oh!

bors commented Jul 15, 2022

Uh oh!

bors commented Jul 15, 2022

Uh oh!

rust-timer commented Jul 15, 2022

Uh oh!

rust-timer commented Jul 15, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

lqd commented Jul 15, 2022

Uh oh!

Mark-Simulacrum commented Jul 15, 2022

Uh oh!

bors commented Jul 15, 2022

Uh oh!

lqd commented Jul 15, 2022

Uh oh!

Mark-Simulacrum commented Jul 23, 2022

Uh oh!

bors commented Jul 23, 2022

Uh oh!

Amanieu commented Jul 23, 2022

Uh oh!

bors commented Jul 24, 2022

Uh oh!

bors commented Jul 24, 2022

Uh oh!

rust-timer commented Jul 24, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Mark-Simulacrum commented Jul 24, 2022

Uh oh!

apiraino commented Jul 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cuviper commented Jul 14, 2022 •

edited

Loading