indexeddb: make put() overwrite existing SQLite records#43721
Merged
Conversation
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
|
🔨 Triggering try run (#23657467273) for Linux (WPT) |
26708c2 to
ea5e9c4
Compare
|
Test results for linux-wpt from try job (#23657467273): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (13)
Stable unexpected results (13)
|
|
|
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
174e9f9 to
f6785f2
Compare
|
🔨 Triggering try run (#23661409333) for Linux (WPT) |
|
Test results for linux-wpt from try job (#23661409333): Flaky unexpected result (25)
Stable unexpected results that are known to be intermittent (15)
|
|
✨ Try run (#23661409333) succeeded. |
TimvdLippe
approved these changes
Mar 29, 2026
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Approving on their behalf
gterzian
reviewed
Mar 30, 2026
| // Step 9. Let targetRealm be a user-agent defined Realm. | ||
| // Step 10. Let clone be a clone of value in targetRealm during transaction. | ||
| // Rethrow any exceptions. | ||
| let cloned_value = structuredclone::write(cx.into(), value, None)?; |
Member
There was a problem hiding this comment.
Here you might want to implement https://www.w3.org/TR/IndexedDB-3/#clone, or note an explicit todo otherwise. (setting transaction activity can be local only in clone)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indexeddb: make put() overwrite existing SQLite records
Testing: more indexeddb test should pass.
Fixes: #43707
Fixes: part of #40983