devtools: Replace new with register for TargetConfigurationActor#43915
Merged
mukilan merged 1 commit intoApr 6, 2026
Merged
Conversation
3299c8f to
cdf5e5d
Compare
mukilan
requested changes
Apr 5, 2026
| let network_parent_name = NetworkParentActor::register(registry); | ||
| let target_configuration = | ||
| TargetConfigurationActor::new(registry.new_name::<TargetConfigurationActor>()); | ||
| let target_configuration = TargetConfigurationActor::register(registry); |
Member
There was a problem hiding this comment.
Suggested change
| let target_configuration = TargetConfigurationActor::register(registry); | |
| let target_configuration_name = TargetConfigurationActor::register(registry); |
| browsing_context_name, | ||
| network_parent_name, | ||
| target_configuration: target_configuration.name(), | ||
| target_configuration, |
Member
There was a problem hiding this comment.
The field name should be updated here.
Suggested change
| target_configuration, | |
| target_configuration_name, |
2 tasks
cdf5e5d to
7845f8c
Compare
7845f8c to
98adea4
Compare
mukilan
requested changes
Apr 6, 2026
| browsing_context_name, | ||
| network_parent_name, | ||
| target_configuration: target_configuration.name(), | ||
| target_configuration: target_configuration_name, |
Member
There was a problem hiding this comment.
Suggested change
| target_configuration: target_configuration_name, | |
| target_configuration_name, |
My previous comment about target_configuration field still applies. We'll need to rename this field in WatcherActor. But the current change is modifying WatcherActor::new which will be be replaced by WatcherActor::register. I'd recommend that you wait until #43911 lands to avoid conflicts and to ensure you are modifying the WatcherActor::register method.
Signed-off-by: Sabb <sarafaabbas@gmail.com>
98adea4 to
16a9a8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced new with register for TargetConfigurationActor in target_configuration.rs & watcher.rs
Testing: No testing required, compiles successfully.
Fixes: Part of #43800