layout: Integrate more details into FontAndScriptInfo#43974
Merged
Conversation
Loirooriol
approved these changes
Apr 8, 2026
| language, | ||
| bidi_level: Level::ltr(), | ||
| letter_spacing, | ||
| word_spacing: None, |
Contributor
There was a problem hiding this comment.
Why pass the actual letter_spacing, but not the actual word_spacing?
Member
Author
There was a problem hiding this comment.
I was thinking that this would only be reached when the segment is entirely control characters and white space, but to be safe I'll pass a real word_spacing here.
| let mut results = Vec::new(); | ||
|
|
||
| let lang = parent_style.get_font()._x_lang.clone(); | ||
| let lang_attribute = parent_style.get_font()._x_lang.clone(); |
Contributor
There was a problem hiding this comment.
Currently we are only using -x-lang for the attribute, but e.g. Firefox also sets it on <math>, so I wouldn't name the variable this way.
| character, | ||
| next_character, | ||
| lang.clone(), | ||
| lang_attribute.clone(), |
Contributor
There was a problem hiding this comment.
Not necessarily in this PR, but might be good to pass the parsed language here?
Member
Author
There was a problem hiding this comment.
I had the same thought actually. It needs a little investigation.
|
🔨 Triggering try run (#24150662584) for Linux (WPT) |
|
Test results for linux-wpt from try job (#24150662584): Flaky unexpected result (42)
Stable unexpected results that are known to be intermittent (17)
|
|
✨ Try run (#24150662584) succeeded. |
This will be needed for ensuring that shaped text is valid during relayout. It duplicates some information, but the hope is that when all of these change are done, there will be many fewer individual shaped segments of text. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
9119355 to
d150d17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be needed for ensuring that shaped text is valid during
relayout. It duplicates some information, but the hope is that when all
of these change are done, there will be many fewer individual shaped
segments of text.
Testing: This should not really change observable behavior so is covered by existing tests.