script: Skip clearing subtree layout boxes of detached element when attaching shadow to it#44052
Merged
Conversation
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Member
|
Do we clear layout boxes when a node is disconnected from the tree? I suspect we might not be doing that. This could lead to a situation where you attach a shadow to a removed node, put it back into the DOM, and then run into the same bug that #42237 was trying to fix. |
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
Member
Author
It seems every code path that disconnects a node guarantees layout boxes are cleared.
|
mrobinson
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no layout boxes to clear in this case. For the example in #43998,
this skips the traversal many times.
Testing: Should not change visible behaviour. Try.