Skip to content

devtools: Do not use MAX_ITEMS in object preview#44173

Merged
atbrakhi merged 1 commit into
servo:mainfrom
atbrakhi:object-preview-item
Apr 13, 2026
Merged

devtools: Do not use MAX_ITEMS in object preview#44173
atbrakhi merged 1 commit into
servo:mainfrom
atbrakhi:object-preview-item

Conversation

@atbrakhi

@atbrakhi atbrakhi commented Apr 13, 2026

Copy link
Copy Markdown
Member

Do not use OBJECT_PREVIEW_MAX_ITEMS in object preview(same as array). With this it matches the Firefox behavior and shows the complete object.

Testing: Current tests are passing.
Fixes: part of #36027
image

Signed-off-by: atbrakhi <atbrakhi@igalia.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 13, 2026
@atbrakhi atbrakhi requested a review from eerii April 13, 2026 16:26
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 13, 2026
@atbrakhi atbrakhi added this pull request to the merge queue Apr 13, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 13, 2026
Merged via the queue into servo:main with commit 8918b6f Apr 13, 2026
34 checks passed
@atbrakhi atbrakhi deleted the object-preview-item branch April 13, 2026 18:32
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 13, 2026
@eerii eerii mentioned this pull request Apr 16, 2026
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants